Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chain metadata for more unit tests #508

Open
bvotteler opened this issue Dec 21, 2022 · 1 comment
Open

Use chain metadata for more unit tests #508

bvotteler opened this issue Dec 21, 2022 · 1 comment
Labels
enhancement New feature or request prio:low

Comments

@bvotteler
Copy link
Contributor

Some unit test register types manually. It would be better to get them dynamically.

See this example in asset-registry tests.

And this relevant discussion on a previous PR: #429 (comment)

So, investigate ways and implement (where possible) more stable ways to set the types needed.
Additional note: Also check out how encoding tests create types using the getTypes() utility function.

@bvotteler bvotteler added the enhancement New feature or request label Dec 21, 2022
@bvotteler bvotteler changed the title Use chain metadata for all unit tests Use chain metadata for more unit tests Dec 21, 2022
@gregdhill
Copy link
Member

We already have the static types from the chain metadata so it should be possible to build these types without an API connection. However with instant-seal now enabled (#578) running the tests is much easier and faster so we might consider just initializing the full API with dynamic types anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:low
Projects
Status: Todo
Development

No branches or pull requests

2 participants