Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission check missing #29

Open
vvvllll opened this issue Jun 15, 2021 · 0 comments
Open

permission check missing #29

vvvllll opened this issue Jun 15, 2021 · 0 comments

Comments

@vvvllll
Copy link

vvvllll commented Jun 15, 2021

Checking the code i noticed there's no permission check, it would be a good idea to add

if(!current_user_can('edit_post', $attachment_id))exit; in save_image()

There's a nonce check but the nonce is visible with any user in admin pages, so even subscribers can add hotspot/faces and recrop all thumbs, and possibly non-auth users as well if they find a way to get a valid nonce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant