Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Two tests likely never run due to unique features in REQUIRES #15838

Closed
ayylol opened this issue Oct 23, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@ayylol
Copy link
Contributor

ayylol commented Oct 23, 2024

Describe the bug

the tests Basic/interop/get_native_ocl.cpp and NewOffloadDriver/diamond_shape.cpp are likely always marked as unsupported due to the features in their requires lines.

Basic/interop/get_native_ocl.cpp: Requires the feature opencl_dev_kit, this is the only place this string appears in the repo.

~/sycl_workspace/llvm$ grep -r "opencl_dev_kit" ./
./sycl/test-e2e/Basic/interop/get_native_ocl.cpp:// REQUIRES: opencl, opencl_dev_kit
~/sycl_workspace/llvm$

NewOffloadDriver/diamond_shape.cpp: Requires the feature fusion. This one we have documented here. However this test and the Readme are the only places this string exists in the test-e2e folder (too many instances outside of this folder to actually go through).

~/sycl_workspace/llvm/sycl/test-e2e$ grep -r "fusion" ./
./README.md: * **fusion**: - Runtime supports kernel fusion;
./NewOffloadDriver/diamond_shape.cpp:// REQUIRES: fusion
./NewOffloadDriver/diamond_shape.cpp:// Test complete fusion with private internalization specified on the
./NewOffloadDriver/diamond_shape.cpp:#include <sycl/ext/codeplay/experimental/fusion_wrapper.hpp>
./NewOffloadDriver/diamond_shape.cpp:  queue q{ext::codeplay::experimental::property::queue::enable_fusion{}};
./NewOffloadDriver/diamond_shape.cpp:    ext::codeplay::experimental::fusion_wrapper fw{q};
./NewOffloadDriver/diamond_shape.cpp:    fw.start_fusion();
./NewOffloadDriver/diamond_shape.cpp:    assert(fw.is_in_fusion_mode() && "Queue should be in fusion mode");
./NewOffloadDriver/diamond_shape.cpp:    fw.complete_fusion({ext::codeplay::experimental::property::no_barriers{}});
./NewOffloadDriver/diamond_shape.cpp:    assert(!fw.is_in_fusion_mode() &&
./NewOffloadDriver/diamond_shape.cpp:           "Queue should not be in fusion mode anymore");
~/sycl_workspace/llvm/sycl/test-e2e$

Additionally from what I can tell the sycl-jit extension is enabled in our ci builds of the compiler. For example when we call cmake in the configure step of this pre-commit build we add the -DSYCL_ENABLE_EXTENSION_JIT=ON flag, however checking the corresponding test runs for this commit, this test is marked as unsupported in all of them.

To reproduce

  1. Include a code snippet that is as short as possible
  2. Specify the command which should be used to compile the program
  3. Specify the command which should be used to launch the program
  4. Indicate what is wrong and what was expected

Environment

  • OS: [e.g Windows/Linux]
  • Target device and vendor: [e.g. Intel GPU]
  • DPC++ version: [e.g. commit hash or output of clang++ --version]
  • Dependencies version: [e.g. the output of sycl-ls --verbose]

Additional context

No response

@ayylol ayylol added the bug Something isn't working label Oct 23, 2024
@ayylol
Copy link
Contributor Author

ayylol commented Oct 23, 2024

Hey @asudarsa, was wondering if you may have knowledge about how the fusion aspect is set.

sarnex pushed a commit that referenced this issue Oct 25, 2024
…#15865)

This test was never ran due to requiring the feature `opencl_dev_kit`.
This patch replaces this with the feature `opencl_icd`, and fixes the
build line to use the `%opencl_lib` expansion.

Fixes part of #15838
sarnex pushed a commit that referenced this issue Oct 25, 2024
This test is never ran because of `REQUIRES: fusion`. This feature used
to be auto-detected, but was removed in #15185. This patch also removes
mentions of this feature from the e2e-test readme.

Fixes part of #15838
@ayylol
Copy link
Contributor Author

ayylol commented Oct 25, 2024

Basic/interop/get_native_ocl.cpp was fixed, and NewOffloadDriver/diamond_shape.cpp was removed.

@ayylol ayylol closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant