Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests #96

Open
1 of 3 tasks
Pennycook opened this issue Apr 4, 2024 · 0 comments
Open
1 of 3 tasks

Improve unit tests #96

Pennycook opened this issue Apr 4, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@Pennycook
Copy link
Contributor

Feature/behavior summary

While working on #87, it became apparent that several of the unit tests are actually end-to-end tests.

For example, instead of testing whether specific directives are parsed correctly, we currently test whether a file containing those directives results in an expected amount of code divergence.

Request attributes

  • Would this be a refactor of existing code?
  • Does this proposal require new package dependencies?
  • Would this change break backwards compatibility?

Related issues

No response

Solution description

I think we should:

  • Identify the minimum set of functionality being tested by each unit test.
  • Rewrite the unit tests to use only the minimum set of functionality.

If there are cases where we believe things should remain an end-to-end test, it may make sense to separate those tests out.

Additional notes

No response

@Pennycook Pennycook added enhancement New feature or request help wanted Extra attention is needed labels Apr 4, 2024
@Pennycook Pennycook added this to the 2.0.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant