Skip to content

Latest commit

 

History

History
127 lines (86 loc) · 4.73 KB

CONTRIBUTING.md

File metadata and controls

127 lines (86 loc) · 4.73 KB
Raw

Contributing Guidelines

We appreciate your contribution to this amazing project! Any form of engagement is welcome, including but not limiting to

  • feature request
  • documentation wording
  • bug report
  • roadmap suggestion
  • ...and so on!

Please refer to the community contributing section for more details.

Development and codebase contribution

Before delving into the details to come up with your first PR, please familiarise yourself with the project structure of Instill Core.

Prerequisites

Pre-commit hooks

check out .pre-commit-config.yaml for the set of hooks that we used

Local development

On the local machine, clone model repository in your workspace, move to the repository folder, and launch all dependent microservices:

$ cd <your-workspace>
$ git clone https://github.com/instill-ai/model.git
$ cd model
$ make latest PROFILE=model

Clone model-backend repository in your workspace and move to the repository folder:

$ cd <your-workspace>
$ git clone https://github.com/instill-ai/model-backend.git
$ cd model-backend

Build the dev image

$ make build

Run the dev container

$ make dev

Now, you have the Go project set up in the container, in which you can compile and run the binaries together with the integration test in each container shell.

Run the server

$ docker exec -it model-backend /bin/bash
$ go run ./cmd/migration
$ go run ./cmd/init
$ CFG_SERVER_ITMODE_ENABLED=true go run ./cmd/main

Run the Temporal worker

$ docker exec -it model-backend /bin/bash
$ CFG_SERVER_ITMODE_ENABLED=true go run ./cmd/worker

Run the unit test

$ make unit-test

Run the integration test

$ docker exec -it model-backend /bin/bash
$ make integration-test

Run with api-gateway mode

$ make integration-test API_GATEWAY_URL=localhost:8080

Stop the dev container

$ make stop

Sending PRs

Please take these general guidelines into consideration when you are sending a PR:

  1. Fork the Repository: Begin by forking the repository to your GitHub account.
  2. Create a New Branch: Create a new branch to house your work. Use a clear and descriptive name, like <your-github-username>/<what-your-pr-about>.
  3. Make and Commit Changes: Implement your changes and commit them. We encourage you to follow these best practices for commits to ensure an efficient review process:
  4. Push to Your Branch: Push your branch to your GitHub repository: git push origin feat/<your-feature-name>.
  5. Open a Pull Request: Initiate a pull request to our repository. Our team will review your changes and collaborate with you on any necessary refinements.

When you are ready to send a PR, we recommend you to first open a draft one. This will trigger a bunch of tests workflows running a thorough test suite on multiple platforms. After the tests are done and passed, you can now mark the PR open to notify the codebase owners to review. We appreciate your endeavour to pass the integration test for your PR to make sure the sanity with respect to the entire scope of Instill Core.

CI/CD

  • pull_request to the main branch will trigger the Integration Test workflow running the integration test using the image built on the PR head branch.
  • push to the main branch will trigger
    • the Integration Test workflow building and pushing the :latest image on the main branch, following by running the integration test, and
    • the Release Please workflow, which will create and update a PR with respect to the up-to-date main branch using release-please-action.

Once the release PR is merged to the main branch, the release-please-action will tag and release a version correspondingly.

The images are pushed to Docker Hub repository.

Last words

Your contributions make a difference. Let's build something amazing together!