Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

do comments in the markdown get included as metadata in the rendered PDF ? #102

Open
zramsay opened this issue Jan 20, 2021 · 2 comments
Open

Comments

@zramsay
Copy link
Contributor

zramsay commented Jan 20, 2021

i.e., it's quite useful to keep clauses in the master template that will be commented out in an actual contract. Does that commented out text block somehow get included in the metadata of the PDF ?

@shonfeder
Copy link
Contributor

I think conditional parameters should be used rather than commented out sections. There are examples of this used in some of our internal templates I think.

That said, there could be other uses for preserving the data from comments in the metadata. I'm not sure what tho, tbh. Instead, I'd think any permanent metadata should go in the yaml header. We don't preserve this in the generated pdfs generally, but I think we could pretty easily.

@zramsay
Copy link
Contributor Author

zramsay commented Jan 21, 2021

the question was more about avoiding information getting into the final PDF that shouldn't be there. Of course the clause/section can be deleted but i was mostly just curious about using comments in the markdown, i.e., do those end up as some sort of metadata in the pdf?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants