fix race condition with statefulset pod recreation startup failure #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the pull request! |
|
!signed-cla |
|
On second thought I am going to take another stab at this from a different angle. This solution breaks idempotency with the webhook which can lead to some unintended behaviour upon further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137
Resolve issue where StatefulSet pods in particular get caught in a race condition when their pods are recreated. There are a few ways to deal with this, but in this case I decided the easiest way would be to check if the pod is owned by a StatefulSet when it's created, and to append a random 5 character string to the end of the secret name.
This required some changes to the delete logic. Instead of assuming the secret name based on the pod name the updated logic gets the secret names from the volume list in the delete admission request.
(if necessary)