Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sidecar containers feature (kubernetes 1.29) #136

Open
jackskj opened this issue Jan 26, 2024 · 6 comments
Open

support sidecar containers feature (kubernetes 1.29) #136

jackskj opened this issue Jan 26, 2024 · 6 comments

Comments

@jackskj
Copy link

jackskj commented Jan 26, 2024

Crashing telegraf container (due to OOM or erroneous configuration) has effect on the main application as the state of the entire pod is set to "not ready" if telegraf is restarted.
In such occurrence, the entire pod will be taken out of kubernetes endpoints and service.

To overcome this issue, kubernetes 1.29 has a "sidecar container" beta feature.
With this feature, the lifecycle of the main pod is separate to that of any sicecar containers.

To implement this feature, telegraf-operator would have to be injected as an iniContiner with restartPolicy set to "always"

Relevant URLs

kubernetes 1.29 sidecar feature

What products and version are you using?

telegraf-operatror: v1.3.11
kubernetes v1.23 (planning to update)

@Pradyumnakashyap
Copy link

Pradyumnakashyap commented Sep 19, 2024

+1

I would like this feature to be added as well !
We use the Telegraf Operator to inject a side car into a Kubernetes Job and we see that the Telegraf container continues to run even after the main container completes.
The above feature would provide us with an option to match the lifecycle with the main container.

@grigory-bogush
Copy link

In our use case we have kubernetes jobs which never finish without timeout due to telegraf being one of the main containers, so it would be nice to have this feature

@0054
Copy link

0054 commented Dec 9, 2024

+1

1 similar comment
@D0Ge3
Copy link

D0Ge3 commented Dec 9, 2024

+1

@chyvak357
Copy link

I can’t stop the Telegraf container without the whole pod going into "not ready" state. Tried everything, and all my searches led me here. Hoping a solution can be found :(

@dploeger
Copy link

dploeger commented Jan 2, 2025

Additionally, the mutating webhook removes "RestartPolicy: Always" from init containers when they are used by other apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants