Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging and error handling for subscriptions #25518

Closed
davidby-influx opened this issue Nov 5, 2024 · 0 comments · Fixed by #25554
Closed

Improve logging and error handling for subscriptions #25518

davidby-influx opened this issue Nov 5, 2024 · 0 comments · Fixed by #25554
Assignees
@davidby-influx
Labels
1.x area/logging area/subscriptions

Comments

@davidby-influx
Copy link
Contributor

davidby-influx commented Nov 5, 2024 •
edited
Loading

Subscription services have a number of problems in their error handling. The Subscriber.Service.Send does not return any errors, which causes the Enterprise SubWriteOk counter to be incremented on both success and failure, which is wrong.

In addition, the logging for the Subscriber service does not use various conventions that would make it easier to debug through the logs. We should put more context in the error messages like database and retention policy, as well as which writer failed (if that information is available).
@davidby-influx davidby-influx self-assigned this Nov 5, 2024
davidby-influx added a commit that referenced this issue Nov 14, 2024
@davidby-influx
feat: improve logging for subscriptions
15ff2d9 
Print the subscription name, destination,
retention policy, and database on errors in subscription writes

closes #25518
@davidby-influx davidby-influx mentioned this issue Nov 14, 2024
Merged
@davidby-influx davidby-influx linked a pull request Nov 14, 2024 that will close this issue
feat: improve logging for subscriptions #25554
Merged
davidby-influx added a commit that referenced this issue Nov 14, 2024
@davidby-influx
feat: improve logging for subscriptions
d2f874b 
Print the subscription name, destination,
retention policy, and database on errors in subscription writes

closes #25518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/logging area/subscriptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve logging for subscriptions influxdata/influxdb
1 participant
@davidby-influx