You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a new gap introduced from the last minute transition from Bors to using GH merge queues.
Previously with Bors, we only relied on checking the success of a single job in ci.yml - Done. The implicit behavior we relied on was the dependency chain defined through the jobs.<job_id>.needs keyword.
While configuring the branch protection rules for merge queues, I followed this pattern with only checking for Done.
Previously from the master branch protections
Two unexpected things happened
The merge check did not block merge from this run even though Done step was skipped
The merge continued even though the run failed
This was probably bc the requirement for non-failing tests was not enabled w/ merge queue
Out of caution, I've turned on every non-merge_group checked job currently in ci.yml as a requirement for merge. This isn't an accessible solution for the devs, since the config is only in the Github Branch protection UI.
A possible solution is to add more jobs to the dependencies of the Done job, so it explicitly includes all our tests
The text was updated successfully, but these errors were encountered:
This is a new gap introduced from the last minute transition from Bors to using GH merge queues.
Previously with Bors, we only relied on checking the success of a single job in
ci.yml
-Done
. The implicit behavior we relied on was the dependency chain defined through thejobs.<job_id>.needs
keyword.While configuring the branch protection rules for merge queues, I followed this pattern with only checking for
Done
.Two unexpected things happened
Done
step was skippedOut of caution, I've turned on every non-
merge_group
checked job currently inci.yml
as a requirement for merge. This isn't an accessible solution for the devs, since the config is only in the Github Branch protection UI.A possible solution is to add more jobs to the dependencies of the
Done
job, so it explicitly includes all our testsThe text was updated successfully, but these errors were encountered: