From 5dad3ed32eeb3d6c742e25f7bbd7090979b03b0b Mon Sep 17 00:00:00 2001 From: Alexander Galibey Date: Mon, 20 Nov 2023 11:15:41 +0400 Subject: [PATCH] chore: remove implicit cluster start from tests --- tests/cli/cdk_smoke_tests/cdk-basic.bats | 3 --- .../cli/cdk_smoke_tests/cdk-multi-partition-consumer.bats | 3 --- tests/cli/cli-platform-cross-version.bats | 3 --- .../fluvio_smoke_tests/non-concurrent/cluster-delete.bats | 3 --- tests/cli/fvm_smoke_tests/fvm_basic.bats | 3 --- tests/cli/smdk_smoke_tests/smdk-basic.bats | 3 --- tests/cli/test_helper/tools_check.bash | 8 -------- 7 files changed, 26 deletions(-) diff --git a/tests/cli/cdk_smoke_tests/cdk-basic.bats b/tests/cli/cdk_smoke_tests/cdk-basic.bats index a82a823a4e5..8fed3602962 100644 --- a/tests/cli/cdk_smoke_tests/cdk-basic.bats +++ b/tests/cli/cdk_smoke_tests/cdk-basic.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/../test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/cdk_smoke_tests/cdk-multi-partition-consumer.bats b/tests/cli/cdk_smoke_tests/cdk-multi-partition-consumer.bats index c067c277f9a..fdc3cbbfb36 100644 --- a/tests/cli/cdk_smoke_tests/cdk-multi-partition-consumer.bats +++ b/tests/cli/cdk_smoke_tests/cdk-multi-partition-consumer.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/../test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/cli-platform-cross-version.bats b/tests/cli/cli-platform-cross-version.bats index 2a59d4d2c8a..b3d7a8c7523 100644 --- a/tests/cli/cli-platform-cross-version.bats +++ b/tests/cli/cli-platform-cross-version.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/fluvio_smoke_tests/non-concurrent/cluster-delete.bats b/tests/cli/fluvio_smoke_tests/non-concurrent/cluster-delete.bats index 2381f68ec71..65f84a8d742 100644 --- a/tests/cli/fluvio_smoke_tests/non-concurrent/cluster-delete.bats +++ b/tests/cli/fluvio_smoke_tests/non-concurrent/cluster-delete.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/../../test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/fvm_smoke_tests/fvm_basic.bats b/tests/cli/fvm_smoke_tests/fvm_basic.bats index 6cab5a5eb71..4b10f0dbcfc 100644 --- a/tests/cli/fvm_smoke_tests/fvm_basic.bats +++ b/tests/cli/fvm_smoke_tests/fvm_basic.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/../test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/smdk_smoke_tests/smdk-basic.bats b/tests/cli/smdk_smoke_tests/smdk-basic.bats index 2111005b9d5..178bd79c958 100644 --- a/tests/cli/smdk_smoke_tests/smdk-basic.bats +++ b/tests/cli/smdk_smoke_tests/smdk-basic.bats @@ -1,8 +1,5 @@ #!/usr/bin/env bats -SKIP_CLUSTER_START=true -export SKIP_CLUSTER_START - TEST_HELPER_DIR="$BATS_TEST_DIRNAME/../test_helper" export TEST_HELPER_DIR diff --git a/tests/cli/test_helper/tools_check.bash b/tests/cli/test_helper/tools_check.bash index 782b27c0637..81433f5ae5f 100644 --- a/tests/cli/test_helper/tools_check.bash +++ b/tests/cli/test_helper/tools_check.bash @@ -12,14 +12,6 @@ main() { check_load_bats_libraries; check_fluvio_bin_path; check_timeout_bin; - - if [[ -n $SKIP_CLUSTER_START ]]; then - #echo "# Skipping cluster start" >&3 - : - else - #echo "# Starting cluster" >&3 - check_fluvio_cluster; - fi } function check_fluvio_bin_path() {