Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .delete() request options interface to include body #131

Open
danipavic opened this issue Sep 28, 2022 · 0 comments
Open

Update .delete() request options interface to include body #131

danipavic opened this issue Sep 28, 2022 · 0 comments

Comments

@danipavic
Copy link

Library's .delete() function takes RequestOptions as the first parameter, however, the interface is missing the body property which you are able to include when making a delete request via Angular HTTP client. The request options interface should be updated to support body.

Current library interface:

export declare type RequestOptions = {
    headers?: HttpHeaders | PlainHeaders;
    observe?: any;
    params?: HttpParams | {
        [param: string]: string | string[];
    } | object;
    routeParams?: {
        [param: string]: string | string[];
    };
    reportProgress?: boolean;
    responseType?: any;
    withCredentials?: boolean;
};

Angular's interface:

{
    headers?: HttpHeaders | {
        [header: string]: string | string[];
    };
    observe: 'response';
    context?: HttpContext;
    params?: HttpParams | {
        [param: string]: string | number | boolean | ReadonlyArray<string | number | boolean>;
    };
    reportProgress?: boolean;
    responseType?: 'json';
    withCredentials?: boolean;
    body?: any | null;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant