Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug related to the 2.1.03 - The server is using FHIR R4 #182

Open
projkov opened this issue Jun 11, 2024 · 1 comment
Open

A bug related to the 2.1.03 - The server is using FHIR R4 #182

projkov opened this issue Jun 11, 2024 · 1 comment

Comments

@projkov
Copy link

projkov commented Jun 11, 2024

There is incorrect behavior for test 2.1.03 - The server is using FHIR R4. It appears this test can be passed with any URL because the issue lies in the fhir_client.

Here is an example of the report: Inferno QA Report.
I used google.com as a server to check, and please look at the result for test 2.1.03. As you can see, this test passed.

This test uses the method fhir_client.detect_version:

server_version = fhir_client.detect_version.to_s.upcase

But let's examine how this method is implemented:
https://github.com/fhir-crucible/fhir_client/blob/b1fff3131ed293eaec1b92885c23645963d9d0a9/lib/fhir_client/client.rb#L94

It seems this method will return R4 when the CapabilityStatement resource is exactly R4 and also when the CapabilityStatement does not exist.

For this particular test, I suggest adding the following extra actions:

  1. Request the capability statement.
  2. Check the response code.
  3. Verify that it is definitely of the CapabilityStatement type.
@dehall
Copy link
Contributor

dehall commented Jun 11, 2024

Yes that definitely looks like a bug. Thanks for reporting this, we've put it on our list to address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants