Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector data contains invalid / misspelled / unknown allegiance codes #240

Open
pmoule opened this issue Jan 21, 2023 · 5 comments
Open

Sector data contains invalid / misspelled / unknown allegiance codes #240

pmoule opened this issue Jan 21, 2023 · 5 comments

Comments

@pmoule
Copy link
Contributor

pmoule commented Jan 21, 2023

Sector data contains a lot of invalid / misspelled / unknown allegiance codes. In surveys this leads to a not complete Alleg section in metadata.

Expectation is, that used codes in a sector's world data should be displayed as allegiances in Alleg section in sector data. As far as I can see, this is exactly your implementation.

Types of invalid codes are different. Sometimes these are simply misspelled wrt casing. Others are completely unknown and not defined in related sector xml. In a different case, allegiance code is different from the one in 'allegiance_code.tab' (e.g. Nx and NaXX). In the latter case generally known code should be used.

Examples:

This pull request fixes all the above in most of the existing sector data.

@inexorabletash
Copy link
Owner

I've been going through and fixing several of these c/o some updated tooling. Ones that will require more research and/or contacting the author to determine intent:

Faraway:

  • Ares - multiple
  • Far Home - Ns
  • Marischal - JD

M1105:

  • Fulani - Nav
  • Harea - Nx, Ns, NX
  • Holowon - He
  • Numbis - J1
  • Phlange - EC

M1120:

  • Lishun - Cv

M1201:

  • Reft - TB
  • Spica - H1
  • Windhorn - Ts
  • Zarushagar - Vc

M1248:

  • Gvurrdon - Cc
  • Massilia - Gc

@pmoule
Copy link
Contributor Author

pmoule commented Jan 23, 2023

ah, great work! This fixes major parts from the original PR's findings.

@pmoule
Copy link
Contributor Author

pmoule commented Jan 23, 2023

M1201:

  • Mesh - Tp

M1105:

  • Phlange - NA (could be Na)

@inexorabletash
Copy link
Owner

inexorabletash commented Feb 18, 2023

Ares and Marischal have corrections now.

inexorabletash added a commit that referenced this issue Apr 7, 2023
Faraway / Far Home - define Ns
M1105 / Fulani - fix Nav to NaXX
M1105 / Harea - fix NX to Nx, define Ns/Nx

For #240
@inexorabletash
Copy link
Owner

That last revision updates:

Faraway / Far Home - define Ns
M1105 / Fulani - fix Nav to NaXX
M1105 / Harea - fix NX to Nx, define Ns/Nx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants