-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sector data contains invalid / misspelled / unknown allegiance codes #240
Comments
I've been going through and fixing several of these c/o some updated tooling. Ones that will require more research and/or contacting the author to determine intent: Faraway:
M1105:
M1120:
M1201:
M1248:
|
ah, great work! This fixes major parts from the original PR's findings. |
M1201:
M1105:
|
Ares and Marischal have corrections now. |
Faraway / Far Home - define Ns M1105 / Fulani - fix Nav to NaXX M1105 / Harea - fix NX to Nx, define Ns/Nx For #240
That last revision updates: Faraway / Far Home - define Ns |
Sector data contains a lot of invalid / misspelled / unknown allegiance codes. In surveys this leads to a not complete Alleg section in metadata.
Expectation is, that used codes in a sector's world data should be displayed as allegiances in Alleg section in sector data. As far as I can see, this is exactly your implementation.
Types of invalid codes are different. Sometimes these are simply misspelled wrt casing. Others are completely unknown and not defined in related sector xml. In a different case, allegiance code is different from the one in 'allegiance_code.tab' (e.g. Nx and NaXX). In the latter case generally known code should be used.
Examples:
This pull request fixes all the above in most of the existing sector data.
The text was updated successfully, but these errors were encountered: