Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add id attribute for extended attribute struct #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add id attribute for extended attribute struct #155

wants to merge 1 commit into from

Conversation

netomi
Copy link

@netomi netomi commented Aug 27, 2024

This fixes #140 .

The Extended Attribute structure has an additional id attribute,

See the output of a header.xml file:

    <ea id="0">
     <name>com.apple.TextEncoding</name>
     <archived-checksum style="sha1">d433dacc26ca2c81f30c25e807dc170e6680aad9</archived-checksum>
     <extracted-checksum style="sha1">34bb265cb6732969f269ccc90fea5d662e9e0ea5</extracted-checksum>
     <encoding style="application/x-gzip"/>
     <size>15</size>
     <offset>41292523</offset>
     <length>23</length>
    </ea>

This fix adds the attribute and writes is accordingly.

@netomi
Copy link
Author

netomi commented Aug 27, 2024

The id field could be made optional to be more resilient when reading xar files that have not set this attribute.
Could not find a xar file format definition so I am not sure if this is mandatory at all.

This was referenced Aug 27, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg signing error
1 participant
@netomi