Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting more and grouping each results by hue representativeness or similarity is needed. #30

Open
metasmile opened this issue Aug 17, 2016 · 0 comments

Comments

@metasmile
Copy link
Contributor

First of all, Thank you for your nice work! Awesome.
But in general case, library users finally needs only 1~2 color groups like primary, secondary or background(outbound) colors. Currently the result seems that in each 2 items are pretty similar. Also in this example https://github.com/indragiek/DominantColor/raw/master/mac.png, I think first color is not dominant color, it may be secondary or background with the last color.

Currently you did perform it by "size" like following.

// Sort the clusters by size in descending order so that the
// most dominant colors come first.
 clusters.sortInPlace { $0.size > $1.size }

Are you have some plans to improve? Or, please let me know some hints or important parts of your lib.

Thanks.

@metasmile metasmile changed the title Sorting and grouping each results by hue representativeness or similarity is more needed. Sorting more and grouping each results by hue representativeness or similarity is needed. Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant