Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET or POST on preview #34

Open
sebsel opened this issue Nov 8, 2018 · 3 comments
Open

GET or POST on preview #34

sebsel opened this issue Nov 8, 2018 · 3 comments

Comments

@sebsel
Copy link
Member

sebsel commented Nov 8, 2018

I found two implementations that do not follow spec, and use GET instead of POST on the Preview action. These are also the only implementation that use the Preview action I could find.

@jackjamieson2
Copy link

Thanks for raising this question.

Yarns Microsub Server will accept either GET or POST for preview - https://github.com/jackjamieson2/yarns-microsub-server/blob/master/includes/class-yarns-microsub-endpoint.php#L217

I think Preview, and Search for that matter, make sense as GET requests

@swentel
Copy link

swentel commented Feb 13, 2019

The Drupal module now supports preview on POST and GET - same for search.
I agree with @jackjamieson2 that GET seems more logical.

Next up - search and preview from Indigenous for Android. I'll be sending a GET request there as I know a lot of people are using aperture.

@aaronpk
Copy link
Member

aaronpk commented Feb 13, 2019

I think my reasoning for requiring POST is that, unlike most read operations, this one will actually cause the server to go do work to fetch the URL and such. It felt like it would be more dangerous to allow that to happen on GETs, which may be easily triggered by CSRF and such, so requiring it be a POST is more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants