Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different result than using Inch 0.8.0 directly from command line #273

Open
okuramasafumi opened this issue Jun 6, 2021 · 1 comment
Open

Comments

@okuramasafumi
Copy link

okuramasafumi commented Jun 6, 2021

When I run bundle exec inch in my repo (https://github.com/okuramasafumi/alba), the result looks like:

# Properly documented, could be improved:
┃  B  ↑  Alba::Resource::ClassMethods#many
┃  B  ↑  Alba::Resource::ClassMethods#one
┃  B  ↑  Alba::Resource::ClassMethods#attributes
┃  B  ↗  Alba::Resource::ClassMethods#attribute
┃  B  ↗  Alba::Resource::ClassMethods#on_error
┃  B  ↗  Alba.on_error
┃  B  ↗  Alba::Resource::InstanceMethods#initialize
┃  B  ↗  Alba::TypedAttribute#initialize

# Not properly documented:
┃  C  ↑  Alba::Association#initialize

# Undocumented:
┃  U  ↗  Alba::Resource::ClassMethods#has_many
┃  U  ↗  Alba::Resource::ClassMethods#has_one
┃  U  ↗  Alba::JSONAPI#converter
┃  U  ↗  Alba.inflector=

You might want to look at these files:

┃ lib/alba/key_transform_factory.rb
┃ lib/alba/default_inflector.rb
┃ lib/alba/typed_attribute.rb
┃ lib/alba/association.rb
┃ lib/alba/resource.rb

Grade distribution (undocumented, C, B, A):  ▁  ▁ ▂ █

Only considering priority objects: ↑ ↗ →  (use `--help` for options).

On the other hand, the web version's result is totally different. https://inch-ci.org/github/okuramasafumi/alba?branch=main

I'm not sure what happens, but the web version uses newer Inch (0.9.0.rc1) so it might be the cause.
I'm happy to help resolving this issue.

@okuramasafumi
Copy link
Author

It turned out that version difference was not the cause. When I run the latest (0.9.0.rc1) Inch in my local environment I get the same result as version 0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant