Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.1: remove dependencies that have now become indirect via etnservice #331

Open
PietrH opened this issue Oct 18, 2024 · 0 comments · May be fixed by #317
Open

v2.3.1: remove dependencies that have now become indirect via etnservice #331

PietrH opened this issue Oct 18, 2024 · 0 comments · May be fixed by #317
Labels
Milestone

Comments

@PietrH
Copy link
Member

PietrH commented Oct 18, 2024

This is quite an easy one, after #317 a number of our dependencies become indirect via etnservice and while there is no real harm in keeping them here, it'll be easier to reduce dependencies if they are only declared on etnservice.

I tried using lintr to detect them, but it seems to be only sensitive to direct calls to library(), another tactic could be to search for namespace declaration ::, or (and this is tempting), removing all dependencies, running R CMD CHECK and looking at the errors.

@PietrH PietrH added the API label Oct 18, 2024
@PietrH PietrH added this to the v2.3.1 milestone Oct 18, 2024
@PietrH PietrH linked a pull request Oct 18, 2024 that will close this issue
8 tasks
@PietrH PietrH linked a pull request Oct 22, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant