Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional worker callbacks #166

Closed
benoitc opened this issue Feb 19, 2019 · 2 comments
Closed

add optional worker callbacks #166

benoitc opened this issue Feb 19, 2019 · 2 comments
Milestone
4.1.0

Comments

@benoitc
Copy link
Contributor

benoitc commented Feb 19, 2019

Starting in erlang 20, a gen_server has optional callbacks like handle_info, terminate and code_change. But the current worker behaviour enforce them. IMO we should expect the worker API to be similar to a gen_server. Thoughts?
@elbrujohalcon elbrujohalcon added this to the 4.1.0 milestone Feb 19, 2019
@elbrujohalcon
Copy link
Member

You're entirely correct. Optional gen_server callbacks should also be optional for wpool.

@elbrujohalcon elbrujohalcon pinned this issue Feb 19, 2019
@elbrujohalcon elbrujohalcon unpinned this issue Oct 15, 2021
@NelsonVides NelsonVides mentioned this issue Aug 3, 2024
Merged
@elbrujohalcon
Copy link
Member

Fixed by #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
2 participants
@benoitc @elbrujohalcon