From 76b6655c89a70d300c2bfa40eea819b389be6f1c Mon Sep 17 00:00:00 2001
From: Alexander Kellner <alexander.kellner@in2code.de>
Date: Fri, 6 Dec 2024 10:44:39 +0100
Subject: [PATCH] [FEATURE] Don't show empty braces in link list in dashboard
 if a newsletter is deleted

Instead show a message that this link was used in a deleted newsletter.
---
 Resources/Private/Language/de.locallang.xlf   |  4 ++
 Resources/Private/Language/locallang.xlf      |  3 ++
 .../Partials/Newsletter/Dashboard/Links.html  | 40 +++++++++++--------
 3 files changed, 31 insertions(+), 16 deletions(-)

diff --git a/Resources/Private/Language/de.locallang.xlf b/Resources/Private/Language/de.locallang.xlf
index 1e0868f1..d167b04d 100644
--- a/Resources/Private/Language/de.locallang.xlf
+++ b/Resources/Private/Language/de.locallang.xlf
@@ -532,6 +532,10 @@
 				<source>Are you sure to delete this record?</source>
 				<target state="translated">Wollen Sie diesen Datensatz wirklich löschen?</target>
 			</trans-unit>
+			<trans-unit id="deletenewsletter">
+				<source>Deleted newsletter</source>
+				<target state="translated">Gelöschter Newsletter</target>
+			</trans-unit>
 			<trans-unit id="defaultLanguage">
 				<source>Default</source>
 				<target state="translated">Standard</target>
diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
index 13f0c44a..8ab6eef0 100644
--- a/Resources/Private/Language/locallang.xlf
+++ b/Resources/Private/Language/locallang.xlf
@@ -403,6 +403,9 @@
 			<trans-unit id="deleteconfirm">
 				<source>Are you sure to delete this record?</source>
 			</trans-unit>
+			<trans-unit id="deletenewsletter">
+				<source>Deleted newsletter</source>
+			</trans-unit>
 			<trans-unit id="defaultLanguage">
 				<source>Default</source>
 			</trans-unit>
diff --git a/Resources/Private/Partials/Newsletter/Dashboard/Links.html b/Resources/Private/Partials/Newsletter/Dashboard/Links.html
index 6890c334..30613669 100644
--- a/Resources/Private/Partials/Newsletter/Dashboard/Links.html
+++ b/Resources/Private/Partials/Newsletter/Dashboard/Links.html
@@ -1,18 +1,26 @@
 <div class="panel panel-default">
-	<div class="panel-heading">
-		<h3 class="panel-title">
-			Links
-		</h3>
-	</div>
-	<div class="panel-body">
-		<ul class="list-group">
-			<f:for each="{groupedLinksByHref}" as="groupedLink">
-				<li class="list-group-item">
-					<span class="badge" style="float: right;" title="Overall">{groupedLink.count}</span>
-					<f:link.external uri="{groupedLink.target}">{groupedLink.target}</f:link.external>
-					<br>({groupedLink.newsletter.title})
-				</li>
-			</f:for>
-		</ul>
-	</div>
+    <div class="panel-heading">
+        <h3 class="panel-title">
+            Links
+        </h3>
+    </div>
+    <div class="panel-body">
+        <ul class="list-group">
+            <f:for each="{groupedLinksByHref}" as="groupedLink">
+                <li class="list-group-item">
+                    <span class="badge" style="float: right;" title="Overall">{groupedLink.count}</span>
+                    <f:link.external uri="{groupedLink.target}">{groupedLink.target}</f:link.external>
+                    <br>
+                    <f:if condition="{groupedLink.newsletter}">
+                        <f:then>
+                            {groupedLink.newsletter.title}
+                        </f:then>
+                        <f:else>
+                            (<f:translate key="LLL:EXT:luxletter/Resources/Private/Language/locallang.xlf:deletednewsletter">Deleted Newsletter</f:translate>)
+                        </f:else>
+                    </f:if>
+                </li>
+            </f:for>
+        </ul>
+    </div>
 </div>