Replace criterion with our test runner on x86 #448
Conversation
ayrtonm
changed the title
|
CI is failing because the (existing) |
|
We should probably also use |
ayrtonm
force-pushed
the
am/remove_criterion
branch
from
0a41a32
to
2904db0
Compare
ayrtonm
changed the title
ayrtonm
force-pushed
the
am/remove_criterion
branch
from
2904db0
to
83a08cc
Compare
| * signal handlers. This file must be included exactly once from a source file | ||
| * in the main binary with IA2_DEFINE_TEST_HANDLER defined by the preprocessor. | ||
| * This will define the functions and variables used by the test handler, ensure | ||
| * it is initialized before main and provide access to the LOG and | ||
| * CHECK_VIOLATION macros. Other files which need CHECK_VIOLATION or LOG may | ||
| * include the header without defining IA2_DEFINE_TEST_HANDLER. Using |
There was a problem hiding this comment.
Is this still true? Do we need to define IA2_DEFINE_TEST_HANDLER?
There was a problem hiding this comment.
oh right, I forgot to update the comments
| auto annotation = fn_ptr_expr->getDecl()->getAttr<clang::AnnotateAttr>(); | ||
| if (annotation && annotation->getAnnotation() == SKIP_WRAP_ATTR) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is this needed for this change? Just wanted to make sure it was related and not accidental.
There was a problem hiding this comment.
yeah, but it's not obvious why so I should've update the documentation in ia2.h. The attribute is added to the function declaration in the Test macro and this branch makes it so that expressions that refer to that dec (e.g. the RHS in .test = fake_criterion_##suite##_##name,) are not rewritten. In the case of Test it wasn't being rewritten since it's expanded from a macro, but the rewriter was printing out warnings about needing to manually rewrite that spot.
There was a problem hiding this comment.
Ideally I would've like to have IA2_{BEGIN,END}_NO_WRAP apply to only things between those macros but I don't think we can annotate expressions so I don't see an obvious way to do this.
This PR also moves the test_fault_handler.h functionality into the test runner. Closes #439