From acde69ee019a734a4672e99c73216ced5cfb725d Mon Sep 17 00:00:00 2001 From: Fabrizio Scarano Date: Mon, 29 Jan 2024 11:59:37 +0100 Subject: [PATCH 1/2] Fixed bug that denies writing to transport on a given level when the latter was equal to the set minimum level --- Glider/Sources/Log/Additional Structures/Level.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Glider/Sources/Log/Additional Structures/Level.swift b/Glider/Sources/Log/Additional Structures/Level.swift index 7a64170..5796719 100644 --- a/Glider/Sources/Log/Additional Structures/Level.swift +++ b/Glider/Sources/Log/Additional Structures/Level.swift @@ -112,7 +112,7 @@ extension Level { return true } - return self.rawValue < minLevel.rawValue + return self.rawValue <= minLevel.rawValue } #if os(iOS) || os(tvOS) || os(macOS) From 284b24a258c0a4a6d48d8e602459b4d962173e56 Mon Sep 17 00:00:00 2001 From: Fabrizio Scarano Date: Mon, 29 Jan 2024 12:25:52 +0100 Subject: [PATCH 2/2] Updated unit test on minimum transport accept level --- Tests/GliderTests/Core+Tests.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Tests/GliderTests/Core+Tests.swift b/Tests/GliderTests/Core+Tests.swift index 5b353fc..6f74b03 100644 --- a/Tests/GliderTests/Core+Tests.swift +++ b/Tests/GliderTests/Core+Tests.swift @@ -57,6 +57,7 @@ final class CoreTests: XCTestCase { /// so you can avoid to write all the messages on it even if logger accepts them. func test_minimumTransportAcceptLevel() throws { var minAcceptedLevel: Glider.Level? = .error + var passedCountWhenSet = 0 var passedCountWhenNil = 0 let transport = TestTransport { event, _ in @@ -64,6 +65,7 @@ final class CoreTests: XCTestCase { if let minAcceptedLevel = minAcceptedLevel { XCTAssertTrue(event.level <= minAcceptedLevel) + passedCountWhenSet += 1 } else { passedCountWhenNil += 1 } @@ -85,6 +87,8 @@ final class CoreTests: XCTestCase { log.error?.write(msg: "[SET] Should pass both") log.critical?.write(msg: "[SET] Should pass both") + XCTAssertEqual(passedCountWhenSet, 2) + // ignore transport.minimumAcceptedLevel = nil minAcceptedLevel = nil