Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code Refactor: Navbar index improvement #22

Open
bozzelliandrea opened this issue Feb 4, 2023 · 4 comments
Open

Clean Code Refactor: Navbar index improvement #22

bozzelliandrea opened this issue Feb 4, 2023 · 4 comments
Assignees
Labels
frontend Frontend issue or improvement good first issue Good for newcomers

Comments

@bozzelliandrea
Copy link
Member

bozzelliandrea commented Feb 4, 2023

the Navbar Component is not very comfortable to read and update, this is because it is written in pure html, it could be improved by managing a json file per subcategory which contains the index and which is loaded during loading of the webapp, the json will populate the navbar entries.

expected result: 3 json files (machine-learning, machine-learning-eng, projective-geo) with json nodes, where each json level has been rendered as ol tag if the level has childs, or li tag if it is empty

@bozzelliandrea bozzelliandrea added good first issue Good for newcomers frontend Frontend issue or improvement labels Feb 4, 2023
@Abhijeet-Gautam5702
Copy link
Contributor

I think I can solve this. Can you please assign me to this issue?
Also, is there a time constraint or a deadline within which this issue must be solved?

@francescodisalvo05
Copy link
Member

Absolutely, thank you for your help!
And no, there isn't a strict time-constraint, as far as you're still working on that 😄

@Abhijeet-Gautam5702
Copy link
Contributor

Thank you very much 😄

bozzelliandrea added a commit that referenced this issue Feb 25, 2023
#22: Refactor Machine-Learning Index section and create machine-learning.json
@bozzelliandrea
Copy link
Member Author

Partially fixed with #25

bozzelliandrea added a commit that referenced this issue Apr 16, 2023
Fixes Issue #22: Refactor Machine-Learning Index section and create separate json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend issue or improvement good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants