-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exchange Config Framework #608
Comments
Duplicate of #551 |
Whoops my bad. Nevertheless I have made some considerable progress on that front that we can discuss 🙂 |
This issue is structured into several tasks: researching and deciding on config libraries, conceptualizing the new config structure and finally, implementation. ResearchFirst of all, we should look at the available libraries and evaluate their pros and cons. Candidates
Criteria
ConceptThere has been some work put into the existing structure of the config. It's fine to start with what already exists and adapt where necessary. Some thought should be put into what parts of the config are or can be optional (and can thus be omitted), and what parts have to be defined for every simulation. Implementation... should only start once all tasks above have been solved. It is fine though to play around with the library candidates in order to evaluate the criteria above. |
Since we have had enough issues in the past with our current configuration derivation I think it's time to switch frameworks.
I'm currently considering https://pureconfig.github.io/ as the main option, as it it also reads HOCON files. We should be able to rip out the old framework, add the new one without breaking older configurations that we have used.
Switching to pureconfig also gives us much more flexibility on how we want to use and setup the configuration as well as the option to document the parameters meaning within the classes, allow more flexible converters for specific fields, e.g. DateTime fields and so on.
The text was updated successfully, but these errors were encountered: