Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite function in PV Model #688

Open
SimonHuette opened this issue Dec 19, 2023 · 2 comments · May be fixed by #689
Open

Rewrite function in PV Model #688

SimonHuette opened this issue Dec 19, 2023 · 2 comments · May be fixed by #689
Assignees
@SimonHuette
Labels
code quality Code readability or efficiency is improved
Milestone
Version 4.0

Comments

@SimonHuette
Copy link
Contributor

Currently, there is a case distinction in the function "calculateBeamOmegas" which adjusts omega1 and omega2 for times close to sunrise or sunset, causing inaccuracies. This case distinction may be simplified, with some slight changes in the function "calcBeamRadiationOnSlopedSurface" aswell.
@SimonHuette SimonHuette added the code quality Code readability or efficiency is improved label Dec 19, 2023
@SimonHuette SimonHuette added this to the Version 4.0 milestone Dec 19, 2023
@SimonHuette SimonHuette self-assigned this Dec 19, 2023
@SimonHuette SimonHuette linked a pull request Dec 20, 2023 that will close this issue
Draft
SimonHuette added a commit that referenced this issue Dec 20, 2023
@SimonHuette
Merge branch 'dev' into sh/#688-rewrite-pv-model
55f24cd
SimonHuette added a commit that referenced this issue Dec 20, 2023
@SimonHuette
Merge remote-tracking branch 'origin/sh/#688-rewrite-pv-model' into sh/…
e7473d0 
…#688-rewrite-pv-model
@SimonHuette
Copy link
Contributor Author

SimonHuette commented Jan 29, 2024 •
edited
Loading

There have been two further problems that I noticed.

  1. In the function calcExtraterrestrialRadiation, there is a wrong digit in the calculation of e0 in the third summand. It is 0.000719 instead of 0.00719 (Duffie(2013) p. 9). I also adjusted the values in the test function.
  2. In the function calfDiffuseRadiationOnSlopedSurface, there was an issue in the calculation of the cloud index epsilon. First, the horizontal beam radiation (code: eBeamH) is used instead of the normal incidence beam radiation (Duffie p. 95). Secondly, we use thetaZ in radians instead of degrees. On Duffie p. 97 there is an example for this.

image

SimonHuette added a commit that referenced this issue Mar 5, 2024
@SimonHuette
Merge branch 'dev' into sh/#688-rewrite-pv-model
88d1062 
# Conflicts:
#	src/main/scala/edu/ie3/simona/model/participant/PvModel.scala
@sebastian-peter
Copy link
Member

I worked a bit on the related PR #689. Now, someone only needs to double-check everything and merge the changes from dev, which includes the new scala test PvModelSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonHuette SimonHuette

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging a pull request may close this issue.

rewrite functions in pv_model ie3-institute/simona
2 participants
@sebastian-peter @SimonHuette