Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for invalid time of primary data #981

Open
t-ober opened this issue Oct 2, 2024 · 2 comments · May be fixed by #1016
Open

Error handling for invalid time of primary data #981

t-ober opened this issue Oct 2, 2024 · 2 comments · May be fixed by #1016
Labels
bug Something isn't working

Comments

@t-ober
Copy link
Contributor

t-ober commented Oct 2, 2024

Currently the simulation stalls when time field of primary data is outside of the range of simulation startDate and endDate.
We should throw an exception in these cases instead rather than leaving the user waiting and wondering / despairing.

The issue can be reproduced by running simona with vn_simona after setting vn_simona.conf to:

simona.time.startDateTime = "2012-01-01T00:00:00Z"
simona.time.endDateTime = "2012-01-01T02:00:00Z"
@sebastian-peter
Copy link
Member

Per our discussion, we should also consider testing cases where timeseries range and simulation time range overlap partly. So in total that'd be:

  • Not a single timeseries date in simulation time range
  • Timeseries starts with a considerable delay after simulation start
  • Timeseries ends with a considerable delay before simulation start

There should be tests for all of this.

@staudtMarius
Copy link
Member

staudtMarius commented Nov 12, 2024

This problem occurres because of ParticipantAgentFundamantals (lines: 142 - 144). One possible fix is shown below.

current:

senderToMaybeTick._2.foreach { tick =>
    scheduler ! Completion(self.toTyped, Some(tick))
}

fixed:

scheduler ! Completion(self.toTyped, senderToMaybeTick._2)

The bug is fixed with #1016. But we could add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants