Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt date column name #1

Open
johanneshiry opened this issue Mar 31, 2021 · 2 comments · May be fixed by #3
Open

Adapt date column name #1

johanneshiry opened this issue Mar 31, 2021 · 2 comments · May be fixed by #3
Assignees
@johanneshiry
Labels
enhancement New feature or request

Comments

@johanneshiry
Copy link
Member

InfluxDB requires the time based field to be named "time". Hence a renaming as suggested in PSDM#175 make sense also for the DWDToolsIconScheme.

Additionally, the existing database needs needs to be adapted accordingly.
@johanneshiry johanneshiry added the enhancement New feature or request label Mar 31, 2021
@johanneshiry johanneshiry self-assigned this Mar 31, 2021
@ckittl ckittl mentioned this issue Mar 31, 2021
Closed
@ckittl ckittl linked a pull request Apr 21, 2021 that will close this issue
Open
@ckittl
Copy link
Member

ckittl commented Jan 28, 2022 •
edited
Loading

In that regard, also check for needed adaptions brought in by ie3-institute/PowerSystemDataModel#516, ie3-institute/PowerSystemDataModel#321 and ie3-institute/PowerSystemDataModel#329

@sebastian-peter
Copy link
Member

As per discussion with @t-ober, it might be a good idea to introduce PSDM as a dependency here and use the field names as defined in corresponding factories, e.g. IconTimeBasedWeatherValueFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanneshiry johanneshiry

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt the column name from "date" to "time" ie3-institute/DWDWeatherTools
3 participants
@sebastian-peter @johanneshiry @ckittl