Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Able to create identity passing to the parameter checkTicketsPeriodMilliseconds negative or zero value #107

Open
rauljareno opened this issue May 18, 2020 · 0 comments
Labels
Milestone

Comments

@rauljareno
Copy link
Contributor

Right now, when sending negative or zero value to the checkTicketsPeriodMillis parameter passed to create an identity, the method is returning the identity without any error. This parameter should be optional or mandatory? I think it should be mandatory as the tickets are needed to completer the full workflow on the library. So if it is mandatory, the best would be not to allow to create an identity with negative milliseconds to check on the tickets, so I suggest to return an error in this case.

Iden3mobile.newIdentity(
"$storePath/alias",
"password",
web3Url,
-10000,
null
) { event -> print(event) }

Result -> Identity is created
Expected -> To not create an identity and return an error requesting the user to introduce a positive value of miliseconds as parameter.

@arnaubennassar arnaubennassar added this to the phase3 milestone Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants