From 61c082022f4dc55ea3320b6c9bad64e11c8d533d Mon Sep 17 00:00:00 2001 From: Guillaume Giudicelli Date: Mon, 23 Dec 2024 16:48:23 +0100 Subject: [PATCH] Remove unused parameters from all fluid properties Improve parameter groups for SIMPLE refs #29609 --- .../src/fluidproperties/FluidProperties.C | 10 ++++++++++ .../IdealRealGasMixtureFluidProperties.C | 4 ---- .../navier_stokes/src/executioners/SIMPLESolveBase.C | 4 ++-- .../src/solidproperties/SolidProperties.C | 11 +++++++++++ 4 files changed, 23 insertions(+), 6 deletions(-) diff --git a/modules/fluid_properties/src/fluidproperties/FluidProperties.C b/modules/fluid_properties/src/fluidproperties/FluidProperties.C index d4f7431eab89..d3c116ef1f1e 100644 --- a/modules/fluid_properties/src/fluidproperties/FluidProperties.C +++ b/modules/fluid_properties/src/fluidproperties/FluidProperties.C @@ -23,6 +23,16 @@ FluidProperties::validParams() params.set("fp_type") = "unspecified-type"; params.addParamNamesToGroup("fp_type allow_imperfect_jacobians", "Advanced"); params.registerBase("FluidProperties"); + + // Suppress unused parameters + params.suppressParameter("use_displaced_mesh"); + params.suppressParameter("execute_on"); + params.suppressParameter("allow_duplicate_execution_on_initial"); + params.suppressParameter("force_preic"); + params.suppressParameter("force_preaux"); + params.suppressParameter("force_postaux"); + params.suppressParameter("execution_order_group"); + return params; } diff --git a/modules/fluid_properties/src/fluidproperties/IdealRealGasMixtureFluidProperties.C b/modules/fluid_properties/src/fluidproperties/IdealRealGasMixtureFluidProperties.C index 8f5ec5fb5511..0de0a6fceed0 100644 --- a/modules/fluid_properties/src/fluidproperties/IdealRealGasMixtureFluidProperties.C +++ b/modules/fluid_properties/src/fluidproperties/IdealRealGasMixtureFluidProperties.C @@ -28,10 +28,6 @@ IdealRealGasMixtureFluidProperties::validParams() "fp_secondary", "Name of fluid properties user object(s) for secondary vapor component(s)"); params.addParam("_T_mix_max", 1300., "Maximum temperature of the mixture"); - // This is necessary because initialize() must be called before any interface - // can be used (which can occur as early as initialization of variables). - params.set("execute_on") = EXEC_INITIAL; - return params; } diff --git a/modules/navier_stokes/src/executioners/SIMPLESolveBase.C b/modules/navier_stokes/src/executioners/SIMPLESolveBase.C index 9006ef8a7a1c..adb33d32c36a 100644 --- a/modules/navier_stokes/src/executioners/SIMPLESolveBase.C +++ b/modules/navier_stokes/src/executioners/SIMPLESolveBase.C @@ -74,7 +74,7 @@ SIMPLESolveBase::validParams() params.addParamNamesToGroup( "momentum_equation_relaxation momentum_petsc_options momentum_petsc_options_iname " "momentum_petsc_options_value momentum_petsc_options_value momentum_absolute_tolerance " - "momentum_l_tol momentum_l_abs_tol momentum_l_max_its", + "momentum_l_tol momentum_l_abs_tol momentum_l_max_its momentum_systems", "Momentum Equation"); /* @@ -121,7 +121,7 @@ SIMPLESolveBase::validParams() params.addParamNamesToGroup( "pressure_variable_relaxation pressure_petsc_options pressure_petsc_options_iname " "pressure_petsc_options_value pressure_petsc_options_value pressure_absolute_tolerance " - "pressure_l_tol pressure_l_abs_tol pressure_l_max_its", + "pressure_l_tol pressure_l_abs_tol pressure_l_max_its pressure_system", "Pressure Equation"); /* diff --git a/modules/solid_properties/src/solidproperties/SolidProperties.C b/modules/solid_properties/src/solidproperties/SolidProperties.C index b6300f10194a..9f1cb9531cc1 100644 --- a/modules/solid_properties/src/solidproperties/SolidProperties.C +++ b/modules/solid_properties/src/solidproperties/SolidProperties.C @@ -8,6 +8,7 @@ //* https://www.gnu.org/licenses/lgpl-2.1.html #include "SolidProperties.h" +#include "MooseObject.h" InputParameters SolidProperties::validParams() @@ -18,6 +19,16 @@ SolidProperties::validParams() false, "true to allow unimplemented property derivative terms to be set to zero for the AD API"); params.registerBase("SolidProperties"); + + // Suppress unused parameters + params.suppressParameter("use_displaced_mesh"); + params.suppressParameter("execute_on"); + params.suppressParameter("allow_duplicate_execution_on_initial"); + params.suppressParameter("force_preic"); + params.suppressParameter("force_preaux"); + params.suppressParameter("force_postaux"); + params.suppressParameter("execution_order_group"); + return params; }