Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart / Pie Grade Distributions Styling Fixes #292

Closed
ethanwong16 opened this issue May 5, 2023 · 1 comment · Fixed by #535
Closed

Chart / Pie Grade Distributions Styling Fixes #292

ethanwong16 opened this issue May 5, 2023 · 1 comment · Fixed by #535
Assignees
@ellisl10
Labels
frontend Front End tasks good first task Good for newcomers Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always.

Comments

@ethanwong16
Copy link
Member

  1. have a single file defining/exporting the color constants to be used for both the chart / pie grade distribution components
  2. make tooltip dimensions / sizes for Pie / Chart Grade distributions consistent

Discovered by @js0mmer in PR #290 , great catch!

Also I noticed some redundancy in the code for Chart and Pie. Both of them use the same colors for the grades but they are defined separately for each component. A future improvement to the codebase would be to have a single file defining/exporting the color constants to be used for each component. Also, I'm not sure why the tooltips are different dimensions/sizes for the Pie and the Chart but I'll just leave it.
@ethanwong16 ethanwong16 added good first task Good for newcomers frontend Front End tasks Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always. labels May 5, 2023
@ethanwong16 ethanwong16 moved this to Fellowship Backlog in PeterPortal Client May 5, 2023
@js0mmer
Copy link
Member

js0mmer commented Nov 1, 2023

Best approach for making tooltips consistent would be to:

  1. disregard the current custom tooltip elements we have defined
  2. Extract the theme in Chart.tsx into a file along with the other shared constants and use it in both Chart and Pie to style tooltips

@js0mmer js0mmer moved this from Fellowship Backlog to Backlog in PeterPortal Client Feb 23, 2024
@js0mmer js0mmer moved this from Backlog to In Progress in PeterPortal Client Dec 7, 2024
@js0mmer js0mmer moved this from In Progress to In Review in PeterPortal Client Dec 10, 2024
@Awesome-E Awesome-E linked a pull request Dec 11, 2024 that will close this issue
Tooltip and chart styling fixes #535
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in PeterPortal Client Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellisl10 ellisl10

Labels
frontend Front End tasks good first task Good for newcomers Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always.
Projects
PeterPortal Client
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tooltip and chart styling fixes icssc/peterportal-client
3 participants
@js0mmer @ethanwong16 @ellisl10