-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IBC version negotiations in IBC java #809
Comments
@sabinchitrakar @izyak DescriptionICON's implementation of Inter-Blockchain Communication (IBC) currently adopts a simplistic approach to version Problem Scenarios
https://github.com/cosmos/ibc/tree/main/spec/core/ics-003-connection-semantics#versioning I have a feeling adding this might just cause us problems as we try to connect to more chains. Since we do not expect people to open random connection to ICON it might be a bad idea to add. What do you guys feel? |
I think it will start to make sense once we have to create patches for different chain based on their version. But i dont think other chains will be making any patches on their end based on our versioning. The doc states |
Yeah but we should not need to create patches for the different chains(hopefully) And if we do, since we establish the connection we can still chose the correct version we want. It would instead be a very annoying scenario if we are prevented to connect to a chain only due to a missing string |
Yeah, I agree. Think for now, it should be alright, if we just check the implementation of the ibc-go before connecting to ICON. The cosmos implementation of ibc-go, as well as the composablefi fork, I believe only has one default version supported anyway. |
Add logic for version negotiation to IBC Java.
Take care to not break the connection to wasm
The text was updated successfully, but these errors were encountered: