Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playsound: Update the window code for SDL2 #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

playsound: Update the window code for SDL2 #50

wants to merge 1 commit into from

Conversation

ccawley2011
Copy link
Contributor

This is now activated via the --window argument, rather than by defining ENABLE_EVENTS.

@sezero
Copy link
Collaborator

sezero commented Mar 29, 2022

Thinking aloud: if we do this, should we remove the SDL_MAIN_HANDLED define? I guess no, one should need a console to use that new --window switch..

@sezero
Copy link
Collaborator

sezero commented Apr 7, 2022

@icculus ?

@sezero
Copy link
Collaborator

sezero commented Apr 14, 2022

Defering to @icculus' judgement.

@icculus icculus self-assigned this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccawley2011 @sezero @icculus