Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opus support #24

Open
berolinux opened this issue Aug 9, 2021 · 8 comments
Open

Add Opus support #24

berolinux opened this issue Aug 9, 2021 · 8 comments

Comments

@berolinux
Copy link
Contributor

SDL_sound currently supports Vorbis files -- but Xiph (maintainers of Vorbis) have deprecated Vorbis in favor of Opus back in 2013. It would be nice to have Opus support in SDL_sound as well.

@sezero
Copy link
Collaborator

sezero commented Aug 18, 2021

As far as I know, @icculus is trying to avoid external library dependencies in SDL_sound-2.0: if you know of an opus decoder that is both mature and also suitably licensed for embedding in SDL_sound - such as those so-called one-header libs, please let us know.

@icculus
Copy link
Owner

icculus commented Mar 24, 2022

@feliwir
Copy link

feliwir commented Mar 29, 2022

A decoder implementation using libopus would not be accepted/viable?

@icculus
Copy link
Owner

icculus commented Apr 7, 2022

A decoder implementation using libopus would not be accepted/viable?

We are avoiding external dependencies beyond SDL2.

@sezero
Copy link
Collaborator

sezero commented Apr 14, 2022

Close this one?

@feliwir
Copy link

feliwir commented Apr 14, 2022

Well, this is still a valid issue.
Maybe there will be a single file opus decoder at some day (not necessarly stb_opus), which can be used.

@icculus
Copy link
Owner

icculus commented Apr 14, 2022

Yeah, leave it open for now, but it's not going to move any time soon.

@ericoporto
Copy link
Contributor

Can't there be an exception in this case with the option of accepting an external dependency for libopus? The license at least looks alright: https://github.com/xiph/opus/blob/main/COPYING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants