Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable release #121

Open
wangjiawen2013 opened this issue Jan 3, 2024 · 3 comments
Open

stable release #121

wangjiawen2013 opened this issue Jan 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@wangjiawen2013
Copy link

wangjiawen2013 commented Jan 3, 2024

Description of feature

Hi,
Thanks for such a great python package ! I want to try using infercnvpy to analyze my single cell data. I notice that there is a warning message on infercnv github:

**
WARNING:

This package is still experimental. The results have not been validated, except in that they look similar, but not identical, to the results of InferCNV.
**

Is it stable now and could we use infercnvpy in our work now ?

@wangjiawen2013 wangjiawen2013 added the enhancement New feature or request label Jan 3, 2024
@grst
Copy link
Member

grst commented Jan 3, 2024

Well, it has been around for a while now and is fairly widely used, so if its results were complete garbage somebody would hopefully have noted by now.

It is still the case that there's no publication, and we did not benchmark it against a gold-standard, or against other methods. There's also no plan from our side to pursue this currently.

@stela2502
Copy link

Just a simple follow up question - why? Why do you not plan to at least compare the results to the R implementation? That should be straight forward - or?
If you do not at least do that - how are you developing this tool?
You statement " and is fairly widely used" - would you mind backing that up?

Thank you!

@grst
Copy link
Member

grst commented May 23, 2024

The usual... this was a side project during my PhD -- I changed jobs since and don't have the time to further pursue this project, except for fixing critical bugs or merging pull requests.

If you want to compare it to the R version and document the results, I'm happy to accept a PR to the documentation.

You statement " and is fairly widely used" - would you mind backing that up?

The project has 119 stars on GitHub and 38k downloads on PyPI. Of course both are imperfect metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants