Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Review CMA-ES implementation #121

Open
btjanaka opened this issue Apr 5, 2021 · 1 comment
Open

[BUG] Review CMA-ES implementation #121

btjanaka opened this issue Apr 5, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@btjanaka
Copy link
Member

btjanaka commented Apr 5, 2021

  • pyribs version: 0.3.1
  • Python version: N/A
  • Operating System: N/A

Description

It seems we may have some errors in the CMA-ES implementation.

For instance, when calculating covariance matrix update (https://github.com/icaros-usc/pyribs/blob/master/ribs/emitters/opt/_cma_es.py#L264), we don't multiply by the sum of the weights, but it looks like they do this in pycma (https://github.com/CMA-ES/pycma/blob/master/cma/purecma.py#L417). This does not matter since the weights sum to 1 anyway, but this would be an issue when implementing active CMA-ES (#85).

As such, we should go thru the CMA-ES implementation and check that it matches the purecma implementation in pycma.

@btjanaka btjanaka added the bug Something isn't working label Apr 5, 2021
@btjanaka btjanaka added this to the v0.5.0 milestone Apr 5, 2021
@tehqin
Copy link
Collaborator

tehqin commented Apr 5, 2021

This value is always one. But we should add this when we implement active-CMA-ES.

@btjanaka btjanaka modified the milestones: v0.5.0, v0.6.0 Feb 23, 2023
@btjanaka btjanaka removed this from the v0.6.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants