Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory issue when testing KPIs using test_kpis.py #672

Closed
Jaap-Neven opened this issue Aug 14, 2024 · 3 comments
Closed

Directory issue when testing KPIs using test_kpis.py #672

Jaap-Neven opened this issue Aug 14, 2024 · 3 comments

Comments

@Jaap-Neven
Copy link
Contributor

While looking at #639, I wanted to run test_kpis.py in order to test the new kpi implementation. This script uses results from testcase2 and testcase3 to obtain the kpi values.

Running all the tests resulted in the error below, where the specified directory can not be found. This snapshot clarifies it crashes for testcase2, but the same error shows for testcase3.

image

Is running test_kpis.py directly the correct way to see if the defined kpis are behaving correctly, or is there another dedicated file doing this without errors? In case of the former, I'll have a look at how to refer to the correct directory.

@dhblum
Copy link
Collaborator

dhblum commented Aug 22, 2024

@Jaap-Neven Thanks for reporting. The best way to run the tests is outlined in /testing/README.md. There you can find instructions for the kpi test, which actually is run within a docker container. Admittedly, this README and those tests were written a while ago and could probably use some updating to make running code easier for dubugging and new users, and potentially make the README more accurate if there have been changes not reflected there in terms of instructions.

@Jaap-Neven
Copy link
Contributor Author

Hi @dhblum, thanks for the response. This makes more sense and the ReadMe file here is still viable imo.

@dhblum
Copy link
Collaborator

dhblum commented Aug 29, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants