Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SimpleHouse tutorial using feedback of Modelica Conference #1803

Closed
1 of 2 tasks
jelgerjansen opened this issue Oct 13, 2023 · 4 comments
Closed
1 of 2 tasks

Comments

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Oct 13, 2023

This issue is to update the SimpleHouse tutorial using feedback from the Modelica Conference. Some feedback I already got during the workshop:

  • The documentation of SimpleHouse3 mentions a nominal mass flow rate of 1 kg/m3 instead of 1 kg/s.
  • The plots in the documentation uses seconds (mega seconds) on the time axis. Days would be a more suitable unit.

@mwetter @LauraMaier @drehelmns @nytschgeusen please let me know if you have any other feedback, then I'll create a development branch and apply these changes.

@mwetter
Copy link
Contributor

mwetter commented Oct 14, 2023

@jelgerjansen : Regarding the plot unit, could you please file an issue on the OpenModelica repository. It would be very convenient to switch between seconds and minutes/hours/days, and also use such a switch in units in the experiment setup window.

@jelgerjansen
Copy link
Contributor Author

I filed the issue of changing the time unit in OM: OpenModelica/OpenModelica#11382
Once this is integrated, I'll update the reference results and create a pull request.

@jelgerjansen
Copy link
Contributor Author

Typo is fixed in #1899, time unit will be fixed in the future once this is integrated in OM

@jelgerjansen
Copy link
Contributor Author

Closed by #1899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants