From 3647796d715cbd41d218c13d3f5005c5b789bc10 Mon Sep 17 00:00:00 2001
From: Wesley Matos <wm4tos.777@gmail.com>
Date: Tue, 17 Oct 2023 08:58:54 -0300
Subject: [PATCH 1/3] feat: trigger onSelectorChange and onValueChange on
 onChange

---
 packages/slate-react/src/plugin/with-react.ts | 18 +++++++++++++++++-
 packages/slate/src/interfaces/editor.ts       |  2 ++
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/packages/slate-react/src/plugin/with-react.ts b/packages/slate-react/src/plugin/with-react.ts
index 21d0ff10b7..9d1258eeb5 100644
--- a/packages/slate-react/src/plugin/with-react.ts
+++ b/packages/slate-react/src/plugin/with-react.ts
@@ -53,7 +53,15 @@ export const withReact = <T extends BaseEditor>(
   clipboardFormatKey = 'x-slate-fragment'
 ): T & ReactEditor => {
   const e = editor as T & ReactEditor
-  const { apply, onChange, deleteBackward, addMark, removeMark } = e
+  const {
+    apply,
+    onChange,
+    onValueChange,
+    onSelectionChange,
+    deleteBackward,
+    addMark,
+    removeMark,
+  } = e
 
   // The WeakMap which maps a key to a specific HTMLElement must be scoped to the editor instance to
   // avoid collisions between editors in the DOM that share the same value.
@@ -366,6 +374,14 @@ export const withReact = <T extends BaseEditor>(
         onContextChange()
       }
 
+      switch (options?.operation?.type) {
+        case 'set_selection':
+          onSelectionChange(options)
+          break
+        default:
+          onValueChange(options)
+      }
+
       onChange(options)
     })
   }
diff --git a/packages/slate/src/interfaces/editor.ts b/packages/slate/src/interfaces/editor.ts
index 3907e89526..f0e01c6309 100644
--- a/packages/slate/src/interfaces/editor.ts
+++ b/packages/slate/src/interfaces/editor.ts
@@ -56,6 +56,8 @@ export interface BaseEditor {
   markableVoid: (element: Element) => boolean
   normalizeNode: (entry: NodeEntry, options?: { operation?: Operation }) => void
   onChange: (options?: { operation?: Operation }) => void
+  onSelectionChange: (options?: { operation?: Operation }) => void
+  onValueChange: (options?: { operation?: Operation }) => void
   shouldNormalize: ({
     iteration,
     dirtyPaths,

From 1b88d8a9621de80a5c2cd08c314fd7a363f1099c Mon Sep 17 00:00:00 2001
From: Wesley Matos <wm4tos.777@gmail.com>
Date: Tue, 17 Oct 2023 09:00:29 -0300
Subject: [PATCH 2/3] docs: add comment

---
 packages/slate-react/src/components/slate.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/slate-react/src/components/slate.tsx b/packages/slate-react/src/components/slate.tsx
index 2e1d69d730..eddc8e6e75 100644
--- a/packages/slate-react/src/components/slate.tsx
+++ b/packages/slate-react/src/components/slate.tsx
@@ -23,6 +23,7 @@ export const Slate = (props: {
   children: React.ReactNode
   onChange?: (value: Descendant[]) => void
 }) => {
+  // do we need to add onValueChange and onSelectorChange here?
   const { editor, children, onChange, initialValue, ...rest } = props
 
   const [context, setContext] = React.useState<SlateContextValue>(() => {

From 7c176e75aa61953b7c58d09fb2d8fab09f7eb7e8 Mon Sep 17 00:00:00 2001
From: Wesley Matos <wm4tos.777@gmail.com>
Date: Tue, 17 Oct 2023 09:22:43 -0300
Subject: [PATCH 3/3] docs: add changeset

---
 .changeset/curly-ligers-lay.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .changeset/curly-ligers-lay.md

diff --git a/.changeset/curly-ligers-lay.md b/.changeset/curly-ligers-lay.md
new file mode 100644
index 0000000000..6ffa5f9ea9
--- /dev/null
+++ b/.changeset/curly-ligers-lay.md
@@ -0,0 +1,6 @@
+---
+'slate': minor
+'slate-react': minor
+---
+
+Add `onValueChange` to watch value changes and `onSelectorChange` to watch selector changes