feat/#5521/derive on selection change and on value change

[ologbonowiwi]

• feat: trigger onSelectorChange and onValueChange on onChange
• docs: add comment
• docs: add changeset

Description
Keep onChange and add onSelectionChange to listen to selection change only and onValueChange to listen to value change only.

Issue
Fixes: #5521
/claim udecode/plate#2700

Checks

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn fix.)
• The relevant examples still work. (Run examples with yarn start.)
• You've added a changeset if changing functionality. (Add one with yarn changeset add.)

cc: @zbeyens

[ologbonowiwi]

@zbeyens let me know if it fills the expectations or there's anything that needs to be changed 😄

[zbeyens]

You need to pass a parameter to this function as stated in #5521 (comment)

[ologbonowiwi]

I'm not getting what you mean. What should I pass as parameter here?

[zbeyens]

We need 2 new props to Slate: onSelectionChange and onValueChange. These callbacks should be called in onContextChange like onChange.

[zbeyens]

Could you add unit tests for:

• Slate prop: onValueChange
• Slate prop: onSelectionChange
• editor method: editor.onValueChange
• editor method: editor.onSelectionChange

[ologbonowiwi]

Where should I add the tests?

[zbeyens]

In packages/slate-react/test and packages/slate/test

[ologbonowiwi]

here is where I need to add the new handlers, @zbeyens?

and execute them inside onContextChange?

or do you want me to add a new parameter on onContextChange, where we'll send the onValueChange/onSelectorChange (from this line)

[zbeyens]

Whatever that makes it work :) Will be confirmed by unit tests.

[zbeyens]

Another contributor has submitted a complete and satisfactory PR #5526. Therefore, this one can be closed. Thank you for your efforts.