Doesn't work if I create Http server on same host but with other port

[CrazyFlasher]

Howerver works if I create websocket server before creating http server.

[ianharrigan]

Hmmm - do you have a minimal example to run? Sounds strange.

[CrazyFlasher]

Doesn't work

import haxe.io.Bytes;
import hx.ws.Log;
import hx.ws.SocketImpl;
import hx.ws.Types.MessageType;
import hx.ws.WebSocket;
import hx.ws.WebSocketHandler;
import hx.ws.WebSocketServer;
import js.node.Http;

class Ws
{
    static public function main()
    {
        #if js
        untyped global.WebSocket = require("ws");
        #end

        var server:js.node.http.Server = Http.createServer();

        server.listen(5000, "localhost", () -> {
            trace("Http server created");

            new Server();
            new Client();
        });
    }
}

class Client {
    public function new() {
        Log.mask = Log.INFO | Log.DEBUG | Log.DATA;
        var ws = new WebSocket("ws://localhost:5001");
        ws.onopen = function() {
            ws.send("alice string");
            ws.send(Bytes.ofString("alice bytes"));
        }
    }
}

class Server {
    public function new() {
        Log.mask = Log.INFO | Log.DEBUG | Log.DATA;
        var server = new WebSocketServer<Handler>("localhost", 5001, 10);
        server.start();
    }
}

class Handler extends WebSocketHandler {
    public function new(s: SocketImpl) {
        super(s);
        onopen = function() {
            trace(id + ". OPEN");
        }
        onclose = function() {
            trace(id + ". CLOSE");
        }
        onmessage = function(message: MessageType) {
            switch (message) {
                case BytesMessage(content):
                    trace(content.readAllAvailableBytes());
                case StrMessage(content):
                    var str = "echo: " + content;
                    trace(str);
                    send(str);
            }
        }
        onerror = function(error) {
            trace(id + ". ERROR: " + error);
        }
    }
}

Works

import haxe.io.Bytes;
import hx.ws.Log;
import hx.ws.SocketImpl;
import hx.ws.Types.MessageType;
import hx.ws.WebSocket;
import hx.ws.WebSocketHandler;
import hx.ws.WebSocketServer;
import js.node.Http;

class Ws
{
    static public function main()
    {
        #if js
        untyped global.WebSocket = require("ws");
        #end

        var server:js.node.http.Server = Http.createServer();

        new Server();
        new Client();

        server.listen(5000, "localhost", () -> {
            trace("Http server created");
        });
    }
}

class Client {
    public function new() {
        Log.mask = Log.INFO | Log.DEBUG | Log.DATA;
        var ws = new WebSocket("ws://localhost:5001");
        ws.onopen = function() {
            ws.send("alice string");
            ws.send(Bytes.ofString("alice bytes"));
        }
    }
}

class Server {
    public function new() {
        Log.mask = Log.INFO | Log.DEBUG | Log.DATA;
        var server = new WebSocketServer<Handler>("localhost", 5001, 10);
        server.start();
    }
}

class Handler extends WebSocketHandler {
    public function new(s: SocketImpl) {
        super(s);
        onopen = function() {
            trace(id + ". OPEN");
        }
        onclose = function() {
            trace(id + ". CLOSE");
        }
        onmessage = function(message: MessageType) {
            switch (message) {
                case BytesMessage(content):
                    trace(content.readAllAvailableBytes());
                case StrMessage(content):
                    var str = "echo: " + content;
                    trace(str);
                    send(str);
            }
        }
        onerror = function(error) {
            trace(id + ". ERROR: " + error);
        }
    }
}

Build command

haxe -js ws.js -main Ws -debug -cp src -lib hxWebSockets -lib hxnodejs

Run command

node ws.js

[ianharrigan]

So i wonder if a better #if is #if nodejs as using just js im pretty sure will break normal, browser js builds.

[CrazyFlasher]

Ok. But the topic of question is another :)

[ianharrigan]

Oh, sorry, got mixed up!

[CrazyFlasher]

Issue is in MainLoop for NodeJS target in this case.
I've changed tick logic for NodeJS to haxe.Timer and works fine for me now.
Created pull request:
#35