Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache option #14

Closed
egemon opened this issue Aug 21, 2019 · 4 comments · May be fixed by #76
Closed

Cache option #14

egemon opened this issue Aug 21, 2019 · 4 comments · May be fixed by #76

Comments

@egemon
Copy link

egemon commented Aug 21, 2019

Thank u for such a great plugin!
Is there anyway to cache somehow results of this plugin?
If this would be loader I would use cache-loader and thread-loader, but I am not quite sure how to use those with this plugin?
Also not sure how imagemin-loader works with this plugin?

@iampava
Copy link
Owner

iampava commented Aug 22, 2019

Hey! I'm on holiday now, I'll have a look at it next week when I come back :)

@iampava
Copy link
Owner

iampava commented Nov 2, 2019

Hey! Sorry for the very very very long delay, I got caught up in work and totally forgot about this. Sooo, I did some quick research and I guess you want to prevent reconverting all images between builds because it takes a long time.

Would disabling the plugin for the development build do the trick? That way you'll have the conversion happening just on production.

If not, I'm thinking of other ways of implementing this instead of converting the plugin to a loader. How about if I offer a "cache-dir" option, and it will convert only images not found in that dir? Would that work for your usecase?

@iampava
Copy link
Owner

iampava commented Nov 14, 2019

Closed this issue due to inactivity. Feel free to open it if you want to continue the discussion on the problem and how best to solve it.

@nerikosans
Copy link

Hi @iampava , thank you for a great plugin!
I opened a pull request #76 to add an option to skip unchanged images, which will work like caching results.
I would be so grateful if you can check and review it.

(I don't have the permission to reopen this issue, I'm afraid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants