Reminders for "at-most" habits never show up

[Yyuzu]

Pre-submission checklist

• I am submitting a bug report, not a feature request.
• I have searched for similar issues, but did not find any matches.

Description

Habits set up as at-most X times per period's reminders never show up.

Steps to reproduce

1. Add a new habit
2. Set it up as no more than 4 times per week
3. Set up a reminder every day at 22:00
4. Reminders never show up

System information

• Phone: Google Pixel 6
• Phone Operating System: GrapheneOS
• App version: 2.2.0 (F-Droid)

Screenshots

nothing relevant

Thank you!

[PickledChris]

I have this issue as well.
Google Pixel 7,
App version v2.2.1

Target: 5 every day
Target type: at most
Reminder 8:10 any day of the week.

I never get the notification, all of my other 5 notifications of different types work fine.

[BSiddharth]

Facing the same issue. On checking the logs, I observed that this is being logged. My guess is somehow this function is sending completed signal for "at most" habits and thus the reminder is being suppressed for those habits. I would have confirmed this theory but after installing android studio, Java and trying to sync gradle for the 100th time I realised I would better prefer to be stabbed in the eyes than dealing with the mess called android development. Also this might be related to our issue #1744.

[BitesizedLion]

I can also confirm that this issue occurs for me as well. :(

Env:
Google Pixel 7 (Android 14)
Version 2.2.1 via Play Store

[ShaqibK]

Can confirm this issue is occouring.
Yes/no habit notifications works everytime, but for measurable habits, there is no notification.

Device:
Mi 11 lite NE 5g
OS: Android 14
App version:2.2.7

[kalina559]

Hey, I had some trouble reproducing this, but in the end I noticed that the problem only appears on my device when the at-most habit already had some input. If the value is 0, the reminder appears as expected.
So this would line up with @BSiddharth suggestion that the habit is treated as 'completed'.

Device:
Motorola Moto G73
OS: Android 14
App version: 2.2.0

[kalina559]

This issue can be solved in at least 2 ways:

1. Making an exception for AT_MOST habits in ShowNotificationTask.onPostExecute(), where we currently skip habits that are marked as completed. PR: Ignoring isCompleted for AT_MOST habits #2078
2. Never treating AT_MOST habits as completed for today. This would also solve "Hide completed" should not hide "At most"-type measured habits #1744. PR: Never mark AT_MOST habits as completed for today #2077

Personally I think that second option is better - AT_MOST habit is not really completed until the day/week/month is over, because otherwise you can still break the limit you set in a habit. @iSoron , @hiqua - what do you think?