ci: define commit scope values #88
Conversation
| @@ -22,6 +22,24 @@ | |||
| 2, | |||
| "always", | |||
| "Signed-off-by" | |||
| ], | |||
| "scope-enum": [ | |||
| 2, | |||
There was a problem hiding this comment.
Shouldn't this be a warning instead of an error? I mean it says "optional" in the above CONTRIBUTING.md explainer.
There was a problem hiding this comment.
In the scope-enum section in https://commitlint.js.org/reference/rules.html has a note
This rule always passes if no scopes are provided in the message or the value > is an empty array.
It seems that the scope is always optional.
There was a problem hiding this comment.
In the scope-enum section in https://commitlint.js.org/reference/rules.html has a note
This rule always passes if no scopes are provided in the message or the value > is an empty array.
It seems that the scope is always optional.
Sounds good to me. I tried to figure out always|never|optional but missed the scope-enum detail (and there is no optional).
Signed-off-by: Akihiko Kuroda <[email protected]>
|
Hi! This is a friendly remainder. Could this be reviewed? Thanks! |
Which issue(s) does this pull-request address?
Closes: #49
Description
Based on the discussion in #49. The current list of scopes are in #49 (comment)
Checklist
yarn lintoryarn lint:fixyarn formatoryarn format:fixyarn test:unityarn test:e2e