Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide secrets when logging emmiter event through framework logger #191

Open
jezekra1 opened this issue Nov 22, 2024 · 0 comments
Open

Hide secrets when logging emmiter event through framework logger #191

jezekra1 opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jezekra1
Copy link
Contributor

jezekra1 commented Nov 22, 2024

If you log the event to console, it will contain the creator property which contains llm instance with client and its credentials. This is a problem if logs from the application with bee-agent-framework are collected to a monitoring stack where other people than the admin of the application have access.

We tell the users to do it here:

To Reproduce
Uncomment the block of code in the bee.ts and run the example (tested with ibm-vllm adapter). You will see credentials in console.

Expected behavior
Filter all sensitive information when using the framework logger.

@jezekra1 jezekra1 added the bug Something isn't working label Nov 22, 2024
@jezekra1 jezekra1 changed the title Leaking secrets in log messages Leaking secrets when logging emmiter event through framework logger Nov 22, 2024
@Tomas2D Tomas2D changed the title Leaking secrets when logging emmiter event through framework logger Hide secrets when logging emmiter event through framework logger Nov 26, 2024
@Tomas2D Tomas2D self-assigned this Nov 26, 2024
@Tomas2D Tomas2D added enhancement New feature or request and removed bug Something isn't working labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants