-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch PythonTool to use HTTP API instead of gRPC #149
Comments
This introduces a breaking change, need to discuss how to rollout |
This will require changes in at least 4 repos. So the initial adds in this list need to land first. Then consumers like bee-api and starter can each update to the new framework/tool/port.
|
Please validate @JanPokorny |
@markstur Is it necessary to add a new tool for HTTP and let it coexist with the gRPC tool? Why can't we make the switch in the framework and then update the Switching would be a breaking change for users that set a custom Code Interpreter URL either way -- and we're on version |
@JanPokorny my initial work was to change the framework tool first, but after trying to test it and thinking about how to make the switch I felt like: 1 - just exposing both in bee-stack is an obvious first step PR I'd like to flip them all ASAP, but it's not all code in one repo so I'd prefer not to have everything broken on our repos main branches for long. Custom code could continue to work the old way with a pinned framework and can easily move forward if we have coexisting support with just the URL setting. Perhaps I also choose to pursue this way because I was already seeing main bee-api incompatible with main bee-framework and it makes it hard to test the whole thing. I feel like the order proposed is safest/simplest until all the places are happy with the new way. But I'm open to shaping those PRs to the maintainers preference. |
@markstur |
Understood, but bee-api was already incompatible with main for unrelated reasons so doing this in pieces would've been more mergeable at the time. We can now focus on just getting this all done instead. That'd be great. I've updated so only HTTP is used for the one and only PythonTool. |
I got a CustomTool working w/ some e2e tests (not mocks yet), but got interrupted by the holidays and probably won't get that cleaned up for the PR until next week (year!). FYI and darn! and happy new year y'all! |
We can switch to https://github.com/i-am-bee/bee-code-interpreter/blob/main/src/code_interpreter/services/http_server.py to simplify our communication pattern.
This would allow us to say bye-bye to
bee-proto
entirely.The text was updated successfully, but these errors were encountered: