-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forking the bundle to include LiberTEM etc. #118
Comments
I don't know if Do you have any specific branding requirement/wishes? If so, you should do a fork and add the logo, change the name, etc. and we would make sure that the repositories stay sufficiently aligned to be compatible. The conda/constructor tooling is much more mature than a few years ago and is not as brittle as before! Otherwise if the added software doesn't increase significantly the size of the bundle, I think it would make sense to include everything. It will more simple for the users, as they will not have to think about it is included, what is not, the difference, etc. At some point, it may be worth thinking about making a variant of the bundle including cupy, etc. which is significantly larger and this is why it is would be worth making a GPU variant. Is there also interest in the portable distribution? |
I guess I've looked into this a little more. I think you might be able to making custom post install dialogues.
Not necessarily. I do want to include our api package, so maybe a fork is a good idea as then we wouldn't have to be as worried about bloating the bundle too much.
We also like to install ImageJ which is available via conda so I might add that. That is also a non-negligable size so it might mean forking is a better idea.
I would be intersted in a GPU variant and might look into that a bit later once I start working more on GPU computing.
I'm not sure I personally have much use for a portable distribution but maybe? Does Constructor support portable distributions? |
The portable distribution is based on winpython. The use case is to make easy to run without having to install, or customise a distribution with development version or specific library version, etc. This is significantly easier than with conda based distribution because the distribution can be customised and then simply and copied and paste to other system, typically without internet access. |
@ericpre Direct electron likes to help install a range of open source software alongside each camera installation, I was thinking about forking the bundle to include additional software such as LiberTEM and maybe the python API for controlling our software.
The other thing I've thought about is including a pop up window in the installation which allows you to select which software you would like installed, in that case I could just contribute directly to the hyperspy-bundle. I'll leave it up to you which version you think is most helpful.
The text was updated successfully, but these errors were encountered: