Problems with Rocksdb

[pSchlarb]

Plenums 3rd parties dependencies use a build of rocksdb from evernym. (https://github.com/evernym/rocksdb)

The built of rocksdb from evernym is not declaring its dependencies such as:
libgflags-dev
libsnappy-dev
zlib1g-dev
libbz2-dev
liblz4-dev
libgflags-dev

References:

indy-plenum/build-scripts/ubuntu-1604/build-3rd-parties.sh

Lines 8 to 23 in 1fa69a1

	function build_rocksdb_deb {
	VERSION=$1
	VERSION_TAG="rocksdb-$VERSION"
	git clone https://github.com/evernym/rocksdb.git /tmp/rocksdb
	cd /tmp/rocksdb
	git checkout $VERSION_TAG
	sed -i 's/-m [email protected]/-m "Hyperledger <[email protected]>"/g' \
	./build_tools/make_package.sh
	PORTABLE=1 EXTRA_CFLAGS="-fPIC" EXTRA_CXXFLAGS="-fPIC" ./build_tools/make_package.sh $VERSION
	# Install it in the system as it is needed by python-rocksdb.
	make install
	cd -
	cp /tmp/rocksdb/package/rocksdb_${VERSION}_amd64.deb $OUTPUT_PATH
	rm -rf /tmp/rocksdb
	}

[WadeBarnes]

When upgrading, investigate using an official package. One that already defines the dependencies properly, hopefully.

[WadeBarnes]

The other issue we have to the Python wrapper being used for rocksdb is out of date, and there seems to be a fracturing of replacement wrappers for it.

[pSchlarb]

@WadeBarnes should we close this issue, since we have a working workaround for the moment?
Or should it stay open as a reminder for the rocksdb upgrades?

[WadeBarnes]

It should stay open. Thanks @pSchlarb

[manolaz]

alright got it