Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-credentials/credential-offers does not return goal or goalCode as described in the docs #1486

Closed
coveloper opened this issue Jan 6, 2025 · 3 comments

Comments

@coveloper
Copy link

Is this a regression?

Yes

Description

Not sure if this is a regression as I am still new to using this API. It does seem to act differently than the documentation describes so maybe it performed differently in the past?

According to the documentation: https://hyperledger.github.io/identus-docs/agent-api/#tag/Issue-Credentials-Protocol/operation/createCredentialOffer I should be able to send a goal and a goalCode and have it reflected back to me in the response.

These fields are not sent back to me.

Example request shown here:

Image Image

Please provide the exception or error you saw

goal and goalCode are not returned in the response as documented.

Please provide the environment you discovered this bug in

cloud-agent-v1.40.0

Anything else?

I am struggling to understand the intent for goal and goalCode if they are not returned.

I would like to populate those with values that only my EdgeClient know so I can track certain responses back and act on only the responses that contain the matching goalCodes.

I am also not seeing goalCode populated in DIDComm Message .body, which is where I really need them to show up.

@mineme0110 mineme0110 self-assigned this Jan 6, 2025
@mineme0110
Copy link
Contributor

documentation in open-api spec is not correct and misleading.
I will update the OpenAPI specification to clarify that goalCode and goal cannot be used with connectionId
goalCode and goal are only applicable to credential offer invitation

@mineme0110
Copy link
Contributor

mineme0110 commented Jan 7, 2025

wrong PR need to still work on this

@mineme0110
Copy link
Contributor

#1493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants