From d4556708b30ddb4a6e4ef244c299084e6ee42c86 Mon Sep 17 00:00:00 2001 From: mkbreuningIOHK Date: Wed, 3 Apr 2024 23:39:35 +0800 Subject: [PATCH 1/2] docs: update code owners and fix pull request template --- .github/CODEOWNERS | 6 +++++- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a4e5d06f3..118c13324 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,6 @@ -@goncalo-frade-iohk @yshyn-iohk @elribonazo @hamada147 @curtis-h @cristianIOHK @amagyar-iohk +# These owners will be the default owners for everything in +# the repo. Unless a later match takes precedence +* @hamada147 +# Docs: +*.md @petevielhaber \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7ef710a99..65624ea68 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,9 +5,9 @@ Summarize the changes you're submitting in a few sentences, including Jira ticke Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas. ### Checklist: -- [] My PR follows the [contribution guidelines](https://github.com/input-output-hk/atala-prism-apollo/blob/main/CONTRIBUTING.md) of this project -- [] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) -- [] I have commented my code, particularly in hard-to-understand areas -- [] I have made corresponding changes to the documentation -- [] I have added tests that prove my fix is effective or that my feature works -- [] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) +- [ ] My PR follows the [contribution guidelines](https://github.com/input-output-hk/atala-prism-apollo/blob/main/CONTRIBUTING.md) of this project +- [ ] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) From 216a5afe977d3556c2f0a8f6006c491d25d11bc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Javier=20Ribo=CC=81=20Labrador?= Date: Tue, 30 Apr 2024 10:01:37 +0200 Subject: [PATCH 2/2] fix: Update codeowners accordingly --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 118c13324..58b215c1f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ # These owners will be the default owners for everything in # the repo. Unless a later match takes precedence -* @hamada147 +* @elribonazo @hamada147 @goncalo-frade-iohk @yshyn-iohk @curtis-h @cristianIOHK @amagyar-iohk # Docs: *.md @petevielhaber \ No newline at end of file